Re: Another regexp performance improvement: skip useless paren-captures - Mailing list pgsql-hackers

From Mark Dilger
Subject Re: Another regexp performance improvement: skip useless paren-captures
Date
Msg-id D6AF940F-C48A-4666-A6E0-B92FC96F0711@enterprisedb.com
Whole thread Raw
In response to Re: Another regexp performance improvement: skip useless paren-captures  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Another regexp performance improvement: skip useless paren-captures  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

> On Aug 8, 2021, at 1:25 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Ugh.  The regex engine is finding the match correctly, but it's failing to
> tell the caller where it is :-(.  I was a little too cute in optimizing
> the regmatch_t result-vector copying in pg_regexec, and forgot to ensure
> that the overall match position would be reported.
>
> Thanks for the testing!

Sure!  Thanks for improving the regular expression engine!

I have applied your latest patch and do not see any problems with it.  All my tests pass with no asserts and with no
differencesin results vs. master.  This is a test suite of nearly 1.5 million separate regular expressions. 

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company






pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Another regexp performance improvement: skip useless paren-captures
Next
From: Tom Lane
Date:
Subject: Re: Another regexp performance improvement: skip useless paren-captures