Re: fix pg_upgrade comment - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: fix pg_upgrade comment
Date
Msg-id D614B25E-B549-49BD-B4D7-1DE0B87B12B7@yesql.se
Whole thread Raw
In response to fix pg_upgrade comment  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: fix pg_upgrade comment
List pgsql-hackers
> On 18 Jun 2024, at 21:50, Nathan Bossart <nathandbossart@gmail.com> wrote:
> 
> I noticed that the "check" variable, which is used for "pg_upgrade
> --check", is commented as follows:
> 
> bool check; /* true -> ask user for permission to make
> * changes */
> 
> This comment was first added when pg_upgrade was introduced (commit
> c2e9b2f288), but I imagine it predates even that.  I've attached a patch to
> fix this.  Barring objections, I'll probably commit this soon.

Nice catch, +1 for committing. 

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: fix pg_upgrade comment
Next
From: Andres Freund
Date:
Subject: Re: Xact end leaves CurrentMemoryContext = TopMemoryContext