Re: Meson far from ready on Windows - Mailing list pgsql-hackers

From Tristan Partin
Subject Re: Meson far from ready on Windows
Date
Msg-id D2R9FY2W0D7S.249249RYHGISR@partin.io
Whole thread Raw
In response to Re: Meson far from ready on Windows  (Andres Freund <andres@anarazel.de>)
Responses Re: Meson far from ready on Windows
List pgsql-hackers
> From 9f7c96dfab4d807e668c9d32b44db5f4ff122e15 Mon Sep 17 00:00:00 2001
> From: Andres Freund <andres@anarazel.de>
> Date: Mon, 8 Jul 2024 15:55:56 -0700
> Subject: [PATCH v2 02/10] Don't define HAVE_[GSSAPI_]GSSAPI_EXT_H
>
> The check for gssapi_ext.h was added in f7431bca8b0. As we require
> gssapi_ext.h to be present, there's no point in defining symbols for the
> header presence.
>
> While at it, use cc.has_header() instead of cc.check_header(), that's a bit
> cheaper and it seems improbably that gssapi.h would compile while gssapi_ext.h
> would not.

improbable

Other than that, it looks pretty solid. Looks like we could help future
us out by teaching compiler.find_library() to take a list of names to
look at similar to how dependency() works now.

Reviewed-by: Tristan Partin <tristan@partin.io>

--
Tristan Partin
Neon (https://neon.tech)



pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: [18] Policy on IMMUTABLE functions and Unicode updates
Next
From: Tomas Vondra
Date:
Subject: Re: walsender.c fileheader comment