RE: libpq debug log - Mailing list pgsql-hackers

From Jamison, Kirk
Subject RE: libpq debug log
Date
Msg-id D09B13F772D2274BB348A310EE3027C64AB163@g01jpexmbkw24
Whole thread Raw
In response to RE: libpq debug log  ("Iwata, Aya" <iwata.aya@jp.fujitsu.com>)
Responses RE: libpq debug log
List pgsql-hackers
Hi Aya-san,

I tested your v3 patch and it seemed to work on my Linux environment.
However, the CF Patch Tester detected a build failure (probably on Windows).
Refer to: http://commitfest.cputube.org/

Docs:
It would be better to have reference to the documentations of 
Frontend/Backend Protocol's "Message Format".

Code:
There are some protocol message types from frontend
that you missed indicating (non BYTE1 types):
CancelRequest (F), StartupMessage (F), SSLRequest (F).

Although I haven't tested those actual protocols,
I assume it will be printed as the following since the length and
message will still be recognized.
ex. Timestamp 8 80877103

So you need to indicate these protocol message types as intended.
ex. Timestamp > SSLRequest 8 80877103


Regards,
Kirk Jamison




pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: standby recovery fails (tablespace related) (tentative patchand discussion)
Next
From: Peter Eisentraut
Date:
Subject: Re: Why does ExecComputeStoredGenerated() form a heap tuple