Re: PATCH: CITEXT 2.0 - Mailing list pgsql-hackers

From David E. Wheeler
Subject Re: PATCH: CITEXT 2.0
Date
Msg-id D0094897-A812-416E-8E8F-3193ACC55BFC@kineticode.com
Whole thread Raw
In response to Re: PATCH: CITEXT 2.0  ("David E. Wheeler" <david@kineticode.com>)
Responses Re: PATCH: CITEXT 2.0  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
Re: PATCH: CITEXT 2.0  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: PATCH: CITEXT 2.0  (Gregory Stark <stark@enterprisedb.com>)
List pgsql-hackers
On Jul 7, 2008, at 12:21, David E. Wheeler wrote:

> My question is: why? Shouldn't they all use the same function for  
> comparison? I'm happy to dupe this implementation for citext, but I  
> don't understand it. Should not all comparisons be executed  
> consistently?

Let me try to answer my own question by citing this comment:
/* * Since we only care about equality or not-equality, we can avoid  
all the * expense of strcoll() here, and just do bitwise comparison. */

So, the upshot is that the = and <> operators are not locale-aware,  
yes? They just do byte comparisons. Is that really the way it should  
be? I mean, could there not be strings that are equivalent but have  
different bytes?

Thanks,

David



pgsql-hackers by date:

Previous
From: "David E. Wheeler"
Date:
Subject: Re: PATCH: CITEXT 2.0 v2
Next
From: Tom Lane
Date:
Subject: Re: the un-vacuumable table