Re: Clean up find_typedefs and add support for Mac - Mailing list pgsql-hackers

From Tristan Partin
Subject Re: Clean up find_typedefs and add support for Mac
Date
Msg-id CXNDPJZ3TMF7.E06EJFULOOZI@neon.tech
Whole thread Raw
In response to Re: Clean up find_typedefs and add support for Mac  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Clean up find_typedefs and add support for Mac
List pgsql-hackers
On Tue Dec 12, 2023 at 5:02 PM CST, Tom Lane wrote:
> "Tristan Partin" <tristan@neon.tech> writes:
> > The big patch here is adding support for Mac. objdump -W doesn't work on
> > Mac. So, I used dsymutil and dwarfdump to achieve the same result.
>
> We should probably nuke the current version of src/tools/find_typedef
> altogether in favor of copying the current buildfarm code for that.
> We know that the buildfarm's version works, whereas I'm not real sure
> that src/tools/find_typedef is being used in anger by anyone.  Also,
> we're long past the point where developers can avoid having Perl
> installed.
>
> Ideally, the buildfarm client would then start to use find_typedef
> from the tree rather than have its own copy, both to reduce
> duplication and to ensure that the in-tree copy keeps working.

That makes sense to me. Where can I find the buildfarm code to propose
a different patch, at least pulling in the current state of the
buildfarm script? Or perhaps Andrew is the best person for this job.

--
Tristan Partin
Neon (https://neon.tech)



pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Built-in CTYPE provider
Next
From: Robert Haas
Date:
Subject: Re: Eager page freeze criteria clarification