Re: pg_upgrade --check fails to warn about abstime - Mailing list pgsql-hackers

From Tristan Partin
Subject Re: pg_upgrade --check fails to warn about abstime
Date
Msg-id CVNXKGJRAAWS.25S80HUEMM7II@neon.tech
Whole thread Raw
In response to pg_upgrade --check fails to warn about abstime  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: pg_upgrade --check fails to warn about abstime
List pgsql-hackers
> +/*
> + * check_for_removed_data_type_usage
> + *
> + *        similar to the above, but for types that were removed in 12.
> + */
> +static void
> +check_for_removed_data_type_usage(ClusterInfo *cluster, const char *datatype)

Seems like you could make this more generic instead of hardcoding
version 12, and then you could use it for any future removed types as
well.

Just a thought.

--
Tristan Partin
Neon (https://neon.tech)



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pg_upgrade --check fails to warn about abstime
Next
From: Alvaro Herrera
Date:
Subject: Re: pg_upgrade --check fails to warn about abstime