Re: subscriptionCheck failures on nightjar - Mailing list pgsql-hackers

From Andres Freund
Subject Re: subscriptionCheck failures on nightjar
Date
Msg-id CE2CE820-8A48-4C0D-B06A-9BD3B1E26D43@anarazel.de
Whole thread Raw
In response to Re: subscriptionCheck failures on nightjar  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Hi,

On September 20, 2019 3:06:20 PM PDT, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>On 2019-Sep-20, Tom Lane wrote:
>
>> Actually, what I did was as attached [1], and I am getting traces
>like
>> [2].  The problem seems to occur only when there are two or three
>> processes concurrently creating the same snapshot file.  It's not
>> obvious from the debug trace, but the snapshot file *does* exist
>> after the music stops.
>
>Uh .. I didn't think it was possible that we would build the same
>snapshot file more than once.  Isn't that a waste of time anyway?
>Maybe
>we can fix the symptom by just not doing that in the first place?
>I don't have a strategy to do that, but seems worth considering before
>retiring the bf animals.

We try to avoid it, but the check is racy. Check comments in SnapBuildSerialize. We could introduce locking etc to
avoidthat, but that seems overkill, given that were really just dealing with a broken os. 

Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: subscriptionCheck failures on nightjar
Next
From: Andres Freund
Date:
Subject: Re: WAL recycled despite logical replication slot