Re: libpq fails to build with TSAN - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: libpq fails to build with TSAN
Date
Msg-id CBCF50B5-39CD-4C97-A893-46932BE919AF@yesql.se
Whole thread Raw
In response to libpq fails to build with TSAN  (Roman Lozko <lozko.roma@gmail.com>)
Responses Re: libpq fails to build with TSAN
List pgsql-hackers
> On 31 Jan 2024, at 04:21, Roman Lozko <lozko.roma@gmail.com> wrote:
>
> Hi, so libpq has this line in its Makefile
> https://github.com/postgres/postgres/blob/6ee26c6a4bafabbd22a85f575d2446fd5ec6ad0d/src/interfaces/libpq/Makefile#L116
> which checks that libpq does not use any "exit" functions. With
> ThreadSanitizer it triggers on function `__tsan_func_exit` which is
> used to record returns from functions. Should it be added to exclusion
> list here?

I think it should, the idea of that check is to catch calls to actual exits,
while this is instrumentation which has nothing to do with exit(2).  The
attached diff should be enough to handle this.

--
Daniel Gustafsson


Attachment

pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: speed up a logical replica setup
Next
From: Bharath Rupireddy
Date:
Subject: Re: Switching XLog source from archive to streaming when primary available