Re: wait event and archive_command - Mailing list pgsql-hackers

From Sascha Kuhl
Subject Re: wait event and archive_command
Date
Msg-id CAPvVvKDh29hnjOn8r+JvsPjYFkf0pxwzmPj18F2vj6Jfutg=Aw@mail.gmail.com
Whole thread Raw
In response to Re: wait event and archive_command  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Great, so great. Thanks you

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> schrieb am Mi., 10. Nov. 2021, 12:20:
On Mon, Nov 1, 2021 at 2:31 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> On 2021/10/21 23:55, Bharath Rupireddy wrote:
> >> Also how about adding wait events for other commands like
> >> archive_cleanup_command, restore_command and recovery_end_command?
> >
> > +1 for the wait event.
>
> Thanks!
> I added the wait events for also restore_command, etc into the patch.
> I attached that updated version of the patch.

Thanks for the patch. It looks good to me other than the following comment:

1) Can't we determine the wait event type based on commandName in
ExecuteRecoveryCommand instead of passing it as an extra param?

Regards,
Bharath Rupireddy.


pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: wait event and archive_command
Next
From: Amit Kapila
Date:
Subject: Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY