Re: perform_spin_delay() vs wait events - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: perform_spin_delay() vs wait events
Date
Msg-id CAPpHfdvnJ4r7GJoHQn8je1OtaF_bhbC3OrRxEY5-zBeCAEwyUQ@mail.gmail.com
Whole thread Raw
In response to Re: perform_spin_delay() vs wait events  (Andres Freund <andres@anarazel.de>)
Responses Re: perform_spin_delay() vs wait events
List pgsql-hackers
On Mon, Nov 21, 2022 at 2:10 AM Andres Freund <andres@anarazel.de> wrote:
> On 2022-11-20 17:26:11 -0500, Robert Haas wrote:
> > On Sun, Nov 20, 2022 at 3:43 PM Andres Freund <andres@anarazel.de> wrote:
> > > I couldn't quite decide what wait_event_type to best group this under? In the
> > > attached patch I put it under timeouts, which doesn't seem awful.
> >
> > I think it would be best to make it its own category, like we do with
> > buffer pins.
>
> I was wondering about that too - but decided against it because it would only
> show a single wait event. And wouldn't really describe spinlocks as a whole,
> just the "extreme" delays. If we wanted to report the spin waits more
> granular, we'd presumably have to fit the wait events into the lwlock, buffers
> and some new category where we name individual spinlocks.

+1 for making a group of individual names spin delays.

------
Regards,
Alexander Korotkov



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: More efficient build farm animal wakeup?
Next
From: Andres Freund
Date:
Subject: Re: perform_spin_delay() vs wait events