Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback - Mailing list pgsql-committers

On Wed, May 7, 2025 at 11:47 AM Aleksander Alekseev
<aleksander@timescale.com> wrote:
> > Refactor ChangeVarNodesExtended() using the custom callback
> >
> > fc069a3a6319 implemented Self-Join Elimination (SJE) and put related logic
> > to ChangeVarNodes_walker().  This commit provides refactoring to remove the
> > SJE-related logic from ChangeVarNodes_walker() but adds a custom callback to
> > ChangeVarNodesExtended(), which has a chance to process a node before
> > ChangeVarNodes_walker().  Passing this callback to ChangeVarNodesExtended()
> > allows SJE-related node handling to be kept within the analyzejoins.c.
>
> I believe this was pushed by mistake.

Why it should be mistake this time?
At least, this time I managed to wait till the end of release freeze.

------
Regards,
Alexander Korotkov
Supabase