Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line
Date
Msg-id CAPpHfdv0uQC0BuFKRWbakFfpUKxzqcm01V6oV5ufyknDwjxTZw@mail.gmail.com
Whole thread Raw
In response to Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
Responses Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line
List pgsql-hackers
On Tue, Feb 25, 2020 at 1:48 PM Alexander Korotkov
<a.korotkov@postgrespro.ru> wrote:
>
> I think usage of chmod() deserves comment.  As I get default
> permissions are sufficient for work, but we need to set them to
> satisfy 'check PGDATA permissions' test.


I've added this comment myself.  I've also fixes some indentation.
Patch now looks good to me.  I'm going to push it if no objections.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment

pgsql-hackers by date:

Previous
From: Vik Fearing
Date:
Subject: Re: Error on failed COMMIT
Next
From: Tomas Vondra
Date:
Subject: Re: Commit fest manager for 2020-03