Hi!
Currently we amcheck supports lossy checking for missing parent
downlinks. It collects bitmap of downlink hashes and use it to check
subsequent tree level. We've experienced some large corrupted indexes
which pass this check due to its looseness.
However, it seems to me we can implement this check in non-lossy
manner without making it significantly slower. We anyway traverse
downlinks from parent to children in order to verify that hikeys are
corresponding to downlink keys. We can also traverse from one
downlink to subsequent using rightlinks. So, if there are some
intermediate pages between them, they are candidates to have missing
parent downlinks. The patch is attached.
With this patch amcheck could successfully detect corruption for our
customer, which unpatched amcheck couldn't find.
Opinions?
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
