Re: [PROPOSAL] Drop orphan temp tables in single-mode - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: [PROPOSAL] Drop orphan temp tables in single-mode
Date
Msg-id CAPpHfdu1kae25eVagyZc-Ahbh56iCrNLRHVRD+k_VQYXdoSenw@mail.gmail.com
Whole thread Raw
In response to [PROPOSAL] Drop orphan temp tables in single-mode  (Arthur Zakirov <a.zakirov@postgrespro.ru>)
List pgsql-hackers
Hi!

On Thu, Mar 7, 2019 at 12:46 PM Arthur Zakirov <a.zakirov@postgrespro.ru> wrote:
> In some cases if PostgreSQL encounters with wraparound PostgreSQL might
> leave created temporary tables even after shutdown.
>
> This orphan temporary tables prevent VACUUM to fix wraparound. It is
> because in single mode VACUUM considers orphan temp tables as temp
> tables of other backends.
>
> Grigory reported that one of our client did stuck with fixing wraparound
> by because he didn't know that he has orphaned temp tables left by a
> backend after wraparound.
>
> This patch fixes the issue. With it VACUUM deletes orphaned tables in
> single mode.
>
> See also thread in general (I'm not sure that orphan temp tables were
> cause here though):
> https://www.postgresql.org/message-id/CADU5SwN6u4radqQgUY2VjEyqXF0KJ6A09PYuJjT%3Do9d7vzM%3DCg%40mail.gmail.com
>
> If the patch is interesting I'll add it to the next commitfest and label
> it as 'v13'.

As far as I understand, it's intended that user should be able to fix
wraparound in single mode.  Assuming this issue may prevent user form
doing this and fix is quite trivial, should we consider backpatching
this?

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


pgsql-hackers by date:

Previous
From: Arthur Zakirov
Date:
Subject: [PROPOSAL] Drop orphan temp tables in single-mode
Next
From: Etsuro Fujita
Date:
Subject: Re: Problems with plan estimates in postgres_fdw