On Thu, Sep 22, 2011 at 3:22 PM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
! /*
! * Calculate delta between penalties of join "common entries" to
! * different groups.
! */
! for (i = 0; i < commonEntriesCount; i++)
{
! double lower,
! upper;
!
! box = DatumGetBoxP(entryvec->vector[commonEntries[i].index].key);
! if (context.dim == 0)
! {
! lower = box->low.x;
! upper = box->high.x;
! }
! else
! {
! lower = box->low.y;
! upper = box->high.y;
! }
! commonEntries[i].delta = Abs(box_penalty(leftBox, box) -
! box_penalty(rightBox, box));
}
'lower' and 'upper' are not used for anything in the above. Is that just dead code that can be removed, or is there something missing that should be using them?
Yes, it's just dead code.
------
With best regards,
Alexander Korotkov.
