Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug - Mailing list pgsql-bugs

From Alexander Korotkov
Subject Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug
Date
Msg-id CAPpHfdtZU6Ai93jhVyMVE8LdsvqbnBRg8ozrHWn+VTFNoRDyZQ@mail.gmail.com
Whole thread Raw
In response to Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug  (David Steele <david@pgmasters.net>)
List pgsql-bugs
On Tue, Mar 6, 2018 at 7:59 PM, David Steele <david@pgmasters.net> wrote:
On 3/6/18 7:04 AM, Teodor Sigaev wrote:
>> I agree with Teodor (upthread, not quoted here) that the documentation
>> could use some editing.
>>
>> I started to do it myself, but quickly realized I have no knowledge of
>> the content.  I'm afraid I would destroy the meaning while updating the
>> grammar.
>>
>> Anyone understand the subject matter well enough to review the
>> documentation?
>
> Liudmila tried to improve docs in Alexander's patchset.
>
> https://www.postgresql.org/message-id/f43b242d-000c-f4c8-cb8b-d37e9752cd93@postgrespro.ru

This looks good to me with a few minor exceptions:

+   <function>word_similarity(text, text)</function> requires further
+   explanation. Consider the following example:

Maybe too verbose?  I think "<function>word_similarity(text,
text)</function> requires further explanation." can be removed entirely.

+   string.  However, this function does not add paddings to the

"add padding"

> BTW, adding Liudmila's message to commitfest task
> (https://commitfest.postgresql.org/17/1403/) doesn't work

Doesn't work for me either.

Alexander, can you post the final patches to the thread so they show up
in the CF app?

I'm sorry for not updating patches, I've missed this message in the thread.

BTW, Teodor have pushed fix to the documentation up to 9.6.

And new function strict_word_similarity() to PostgreSQL 11.
I don't have enough of reputation to comment.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

pgsql-bugs by date:

Previous
From: Greg Clough
Date:
Subject: RE: BUG #15067: Documentation or behaviour bug with autovacuumthresholds?
Next
From: Teodor Sigaev
Date:
Subject: Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug