Postgres Pro
Downloads
Home   >   mailing lists

Lock mode in ExecMergeMatched() - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Lock mode in ExecMergeMatched()
Date
Msg-id CAPpHfdtW9+Brf8R2QD5dMrkxdbG-5R_GHx4YS_VVKMhQWGSifQ@mail.gmail.com
Whole thread Raw
Responses Re: Lock mode in ExecMergeMatched()  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Re: Lock mode in ExecMergeMatched()  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Tree view 
Hi!

I wonder why does ExecMergeMatched() determine the lock mode using
ExecUpdateLockMode().  Why don't we use lock mode set by
table_tuple_update() like ExecUpdate() does?  I skim through the
MERGE-related threads, but didn't find an answer.

I also noticed that we use ExecUpdateLockMode() even for CMD_DELETE.
That ends up by usage of LockTupleNoKeyExclusive for CMD_DELETE, which
seems plain wrong for me.

The proposed change is attached.

------
Regards,
Alexander Korotkov
Attachment

pgsql-hackers by date:

Previous
From: "Regina Obe"
Date:
Subject: RE: Ability to reference other extensions by schema in extension scripts
Next
From: Nathan Bossart
Date:
Subject: Re: recovery modules