Re: lastOverflowedXid does not handle transaction ID wraparound - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: lastOverflowedXid does not handle transaction ID wraparound
Date
Msg-id CAPpHfdtQNaK0pNKa14XZ3Ky9tAorvEMrqUR3SancZQUG6OkwMg@mail.gmail.com
Whole thread Raw
In response to Re: lastOverflowedXid does not handle transaction ID wraparound  (Simon Riggs <simon.riggs@enterprisedb.com>)
Responses Re: lastOverflowedXid does not handle transaction ID wraparound
Re: lastOverflowedXid does not handle transaction ID wraparound
Re: lastOverflowedXid does not handle transaction ID wraparound
List pgsql-hackers
Hi!

On Wed, Nov 3, 2021 at 8:51 PM Simon Riggs <simon.riggs@enterprisedb.com> wrote:
> It is however, an undocumented modularity violation. I think that is
> acceptable because of the ProcArrayLock traffic, but needs to have a
> comment to explain this at the call to
> ExpireOldKnownAssignedTransactionIds() i.e. " and potentially reset
> lastOverflowedXid", as well as a comment on the
> ExpireOldKnownAssignedTransactionIds() function.

Thank you for your feedback.  Please find the revised patch attached.
It incorporates this function comment changes altogether with minor
editings and commit message. Let me know if you have further
suggestions.

I'm going to push this if no objections.

------
Regards,
Alexander Korotkov

Attachment

pgsql-hackers by date:

Previous
From: David Christensen
Date:
Subject: Re: CREATE ROLE IF NOT EXISTS
Next
From: Peter Smith
Date:
Subject: Re: row filtering for logical replication