Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15) - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)
Date
Msg-id CAPpHfdspaT9iZUV-vM1wbMZ4aBD6347UWXVZH8UYfjJdeDdjcw@mail.gmail.com
Whole thread Raw
In response to Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)  (Alexander Lakhin <exclusion@gmail.com>)
List pgsql-hackers
Андрей, привет!

Текущее положение у меня такое.

.pg_stats and range statistics
Tracking statements entry timestamp in pg_stat_statements


Уже закоммичены.

XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

Если всё будет и замечаний не возникнет ок, завтра утром закоммичу.

Add semi-join pushdown to postgres_fdw

Переработал патч, сделал обработку условий более аккурантно. Хочу попросить ещё 2 часа на финальное ревью и коммит.

May be BUG. Periodic burst growth of the checkpoint_req counter on replica.

Сегодня вечером планирую доделать и выложить review.

------
Regards,
Alexander Korotkov

------
Regards,
Alexander Korotkov


On Mon, Nov 27, 2023 at 9:00 AM Alexander Lakhin <exclusion@gmail.com> wrote:
Hello Alexander,

27.11.2023 02:43, Alexander Korotkov wrote:

> v61 looks good to me.  I'm going to push it as long as there are no objections.
>

I've looked at the patch set and found a typo:
occured

And a warning:
$ CC=gcc-12 CFLAGS="-Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -Wno-clobbered
-Wno-missing-field-initializers" ./configure -q && make -s
slru.c:63:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
    63 | static int      inline
       | ^~~~~~

Maybe it's worth fixing before committing...

Best regards,
Alexander

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: [PoC] pg_upgrade: allow to upgrade publisher node
Next
From: "Drouvot, Bertrand"
Date:
Subject: Re: Synchronizing slots from primary to standby