Re: Dimension limit in contrib/cube (dump/restore hazard?) - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: Dimension limit in contrib/cube (dump/restore hazard?)
Date
Msg-id CAPpHfdshw4tFg1RAX3_sdbgeiB7FRCf7wJqKytx6p2=y2VGuxw@mail.gmail.com
Whole thread Raw
In response to Re: Dimension limit in contrib/cube (dump/restore hazard?)  (Andrey Borodin <x4mmm@yandex-team.ru>)
Responses Re: Dimension limit in contrib/cube (dump/restore hazard?)
List pgsql-hackers
Hi!

On Tue, Aug 28, 2018 at 6:21 PM Andrey Borodin <x4mmm@yandex-team.ru> wrote:
> I belive cube construction from array\arrays should check size of arrays.

Makes sense to me.

> Also there are some unexpected cube dimensionality reduction like in cube_enlarge
>     if (n > CUBE_MAX_DIM)
>         n = CUBE_MAX_DIM;
> You wanted larger cube, but got cube of another dimension.
>
> I think we should something like this

OK, but I think cube_c_f8() and cube_c_f8_f8() also need to be
revised.  Also, I think this behavior should be covered by regression
tests.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: TupleTableSlot abstraction
Next
From: Jeremy Finzel
Date:
Subject: Re: Some pgq table rewrite incompatibility with logical decoding?