Re: Removing unneeded self joins - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: Removing unneeded self joins
Date
Msg-id CAPpHfds_s7PvwpUAjzhTy730cR3duvVYG2Asy85mzMvTyqtErA@mail.gmail.com
Whole thread Raw
In response to Re: Removing unneeded self joins  (Alexander Korotkov <aekorotkov@gmail.com>)
List pgsql-hackers
On Sat, Apr 26, 2025 at 11:04 PM Alexander Korotkov
<aekorotkov@gmail.com> wrote:
> On Sun, Apr 6, 2025 at 12:02 AM Alena Rybakina
> <a.rybakina@postgrespro.ru> wrote:
> > Should we add more regression tests covering these cases?
> >
> > I experimented with some examples like this and noticed that it does affect cardinality estimation, though I'm not
surethe impact is significant. 
> > I used the tables from the regression tests, so if they’re appropriate for reproducing this case, it should be
straightforwardto add them. 
>
> Thank you for your feedback.  I've check the cases you've provided.  I
> found that the differences here are related to the SJE itself, not to
> changes regarding PHVs handling.  I think it generally OK that
> estimates are somewhat changed due to such significant query
> transformation.  Hopefully they should be improved in the majority of
> cases.
>
> I did some improvements to PHVs patch: revised comments and commit
> message.  I'm going to push it if no objections.

Uh, v2 was there already.  That should be v3.

------
Regards,
Alexander Korotkov
Supabase

Attachment

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Removing unneeded self joins
Next
From: Tomas Vondra
Date:
Subject: Re: Get rid of integer divide in FAST_PATH_REL_GROUP() macro