Postgres Pro
Downloads
Home   >   mailing lists

Re: Patch for ginCombineData - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: Patch for ginCombineData
Date
Msg-id CAPpHfdsOA6Q-N=X6OjcRAd1TqkB8aKTn5hZ=8wVL3V=aYo=SYQ@mail.gmail.com
Whole thread Raw
In response to Patch for ginCombineData  (Robert Abraham <robert.abraham86@googlemail.com>)
List pgsql-hackers
Tree view
Hi!

On Wed, Aug 5, 2015 at 1:17 PM, Robert Abraham <robert.abraham86@googlemail.com> wrote:
we are using gin indexes on big tables. these tables happen to have several billion rows.
the index creation fails in ginCombineData in src/backend/access/ginbulk.c because repalloc is limited to 1 gb.
this limitation makes no sense in this context (compare comments in src/include/utils/memutils.h).
To overcome this limitation on tables with lots of rows repalloc_huge is used.
The test suite still succeeds on my machine.
Find the patch attached,

Thank you for notice and for the patch!
You should have maintenance_work_mem > 1gb and some very frequent entry so that it's posting list exceeds 1 gb itself.
These circumstances shouldn't be very rare in modern systems. I think it could be backpatched.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company 

pgsql-hackers by date:

Previous
From: Nikolay Shaplov
Date:
Subject: Re: pageinspect patch, for showing tuple data
Next
From: Andres Freund
Date:
Subject: Re: Reduce ProcArrayLock contention