Re: A strange GiST error message or fillfactor of GiST build - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: A strange GiST error message or fillfactor of GiST build
Date
Msg-id CAPpHfdsJwptVsRnBtTdtj+G+gTTfSrqdH1uwLNkvQ-72A9scgw@mail.gmail.com
Whole thread Raw
In response to Re: A strange GiST error message or fillfactor of GiST build  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Responses Re: A strange GiST error message or fillfactor of GiST build  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
List pgsql-hackers
On Tue, Sep 4, 2018 at 12:16 PM Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> I agree that fillfactor should be ignored in certain cases
> (inserting the first tuple into empty pages or something like
> that). Even though GiST doesn't need fillfactor at all, it is
> defined independently from AM instances

What exactly do you mean?  Yes, fillfactor is defined in StdRdOptions
struct, which is shared across many access methods.  But some of them
uses fillfactor, while others don't.  For instance, GIN and BRIN don't
support fillfactor at all.

> and it gives some
> (undocumented) convenient on testing even on GiST.

Do you keep in the mind some particular use cases?  If so, could you
please share them.  It would let me and others understand what
behavior we need to preserve and why.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


pgsql-hackers by date:

Previous
From: Georgy Buranov
Date:
Subject: Re: PostgreSQL logical decoder output plugin - unchanged toast data
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: [HACKERS] Restricting maximum keep segments by repslots