Postgres Pro
Downloads
Home   >   mailing lists

Re: GIN logging GIN_SEGMENT_UNMODIFIED actions? - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: GIN logging GIN_SEGMENT_UNMODIFIED actions?
Date
Msg-id CAPpHfds5_ayQpmt0Z5qX7K2M6qT7LGD3A7xZzO8YhHFHxzAYdQ@mail.gmail.com
Whole thread Raw
In response to GIN logging GIN_SEGMENT_UNMODIFIED actions?  (Andres Freund <andres@anarazel.de>)
Responses Re: GIN logging GIN_SEGMENT_UNMODIFIED actions?
List pgsql-hackers
Tree view
Hi!

On Mon, May 9, 2016 at 10:46 PM, Andres Freund <andres@anarazel.de> wrote:
trying to debug something I saw the following in pg_xlogdump output:

rmgr: Gin         len (rec/tot):      0/   274, tx:          0, lsn: 1C/DF28AEB0, prev 1C/DF289858, desc: VACUUM_DATA_LEAF_PAGE  3 segments: 5 unknown action 0 ???, blkref #0: rel 1663/16384/16435 blk 310982

note the "segments: 5 unknown action 0 ???" bit.  That doesn't seem
right, given:
#define GIN_SEGMENT_UNMODIFIED  0               /* no action (not used in WAL records) */

I've checked GIN code.  Have no idea of how such wal record could be generated...
The only idea I have is to add check that we're inserting valid WAL record immediately before XLogInsert().

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company 

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Patch for German translation
Next
From: Kevin Grittner
Date:
Subject: Re: what to revert