Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message. - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.
Date
Msg-id CAPmGK174_9SOx2M+-SJw=TXRL6xJayrVFjf7UX+mAMuLQzg6cQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdwmessage.  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdwmessage.  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
Hi Michael-san,

On Wed, Nov 6, 2019 at 4:35 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Wed, Nov 06, 2019 at 03:12:04PM +0900, Etsuro Fujita wrote:
> > On Wed, Nov 6, 2019 at 1:13 PM Michael Paquier <michael@paquier.xyz> wrote:
> >> "postgres_fdw foreign tables" sounds weird to me.  Could "foreign
> >> tables using postgres_fdw" be a better wording?  I am wondering as
> >> well if we should not split this information into two parts: one for
> >> the actual error message which only mentions foreign tables, and a
> >> second one with a hint to mention that postgres_fdw has been used.
> >
> > We use "postgres_fdw foreign tables" or "postgres_fdw tables" in
> > release notes, so I thought it was OK to use that in error messages as
> > well.  But actually, these wordings are not suitable for error
> > messages?
>
> It is true that the docs of postgres_fdw use that and that it is used
> in some comments.  Still, I found this wording a bit weird..  If you
> think that what you have is better, I am also fine to let you have the
> final word, so please feel to ignore me :)

I'd like to hear the opinions of others.

Best regards,
Etsuro Fujita



pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: pgbench - rework variable management
Next
From: Dilip Kumar
Date:
Subject: Re: [HACKERS] Block level parallel vacuum