Postgres Pro
Downloads
Home   >   mailing lists

Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT
Date
Msg-id CAPmGK16iznMWWEof5fk7XMTuRoASe4KqKsW6oDHdfUbs-hD=ng@mail.gmail.com
Whole thread Raw
In response to Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT  (Amit Langote <amitlangote09@gmail.com>)
Responses Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT
List pgsql-hackers
Tree view 
Amit-san,

On Fri, May 27, 2022 at 9:22 PM Amit Langote <amitlangote09@gmail.com> wrote:
> On Fri, May 27, 2022 at 7:15 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> >  Attached is a patch for that.

> I think we should also rewrite the description to match the CREATE
> TABLE's text, as in the attached updated patch.

Actually, I thought the description would be OK as-is, because it says
“See the similar form of CREATE TABLE for more details”, but I agree
with you; it’s much better to also rewrite the description as you
suggest.

I’ll commit the patch unless Robert wants to.

Thanks for the review and patch!

Best regards,
Etsuro Fujita

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns
Next
From: Masahiko Sawada
Date:
Subject: Re: Support logical replication of DDLs