Postgres Pro
Downloads
Home   >   mailing lists

Re: BEFORE UPDATE trigger on postgres_fdw table not work - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: BEFORE UPDATE trigger on postgres_fdw table not work
Date
Msg-id CAPmGK15wYher5pdOBPQZvwiZHBgPTuWh-=RwEY-SxC_MfP7i0g@mail.gmail.com
Whole thread Raw
In response to RE: BEFORE UPDATE trigger on postgres_fdw table not work  (<shohei.mochizuki@toshiba.co.jp>)
Responses RE: BEFORE UPDATE trigger on postgres_fdw table not work
List pgsql-hackers
Tree view 
Mochizuki-san,

On Wed, Jun 12, 2019 at 6:08 PM <shohei.mochizuki@toshiba.co.jp> wrote:
> > On Mon, Jun 10, 2019 at 9:04 PM Etsuro Fujita <etsuro.fujita@gmail.com>
> > wrote:
> > > I'll look into the patch more closely tomorrow.
> >
> > I did that, but couldn't find any issue about the patch.  Here is an updated
> > version of the patch.  Changes are:
> >
> > * Reworded the comments a bit in postgresPlanFoereignModify the original
> > patch modified
> > * Added the commit message

> I think your wording is more understandable than my original patch.

Great!  I've pushed the patch after updating the comment as proposed
by Amit-san yesterday, and adding a regression test case checking
EXPLAIN because otherwise we wouldn't have any EXPLAIN results in
v9.4.

Thanks for the report and fix!

Best regards,
Etsuro Fujita

pgsql-hackers by date:

Previous
From: movead li
Date:
Subject: Re: Rearranging ALTER TABLE to avoid multi-operations bugs
Next
From: "Jamison, Kirk"
Date:
Subject: RE: [PATCH] Speedup truncates of relation forks