Re: d25ea01275 and partitionwise join - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: d25ea01275 and partitionwise join
Date
Msg-id CAPmGK15+5RJS8cdPtQ25FBcwX5dLgtXFjkU1ZZ_0CRa6KqOzPw@mail.gmail.com
Whole thread Raw
In response to d25ea01275 and partitionwise join  (Amit Langote <amitlangote09@gmail.com>)
Responses Re: d25ea01275 and partitionwise join
List pgsql-hackers
On Tue, Jul 2, 2019 at 6:29 PM Amit Langote <amitlangote09@gmail.com> wrote:
> 0001 - fix partitionwise join to work correctly with n-way joins of
> which some are full joins (+ cosmetic improvements around the code
> that was touched)

Here are my comments about the cosmetic improvements: they seem pretty
large to me, so I'd make a separate patch for that.  In addition, I'd
move have_partkey_equi_join() and match_expr_to_partition_keys() to
relnode.c, because these functions are only used in that file.

Best regards,
Etsuro Fujita



pgsql-hackers by date:

Previous
From: Sergei Kornilov
Date:
Subject: Re: Change ereport level for QueuePartitionConstraintValidation
Next
From: Dilip Kumar
Date:
Subject: Re: POC: Cleaning up orphaned files using undo logs