Re: warning to publication created and wal_level is not set to logical - Mailing list pgsql-hackers

From Lucas Viecelli
Subject Re: warning to publication created and wal_level is not set to logical
Date
Msg-id CAPjy-57VkFhHGLY2rtUNjBxN_GwcvbyfEh=bDCAMN3uJLNuV3g@mail.gmail.com
Whole thread Raw
In response to Re: warning to publication created and wal_level is not set to logical  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: warning to publication created and wal_level is not set to logical  (Lucas Viecelli <lviecelli199@gmail.com>)
List pgsql-hackers
Hi Thomas.

Attached is the rebased
 
The July Commitfest has started.  This patch is in "Needs review"
status, but it doesn't apply.  If I read the above discussion
correctly, it seems there is agreement that a warning here is a good
idea to commit this patch.  Could you please post a rebased patch?


I followed your suggestion and changed the message and added HINT. I hope everything is agreed now.
 
I wonder if it would be more typical project style to put the clue on
what to do into an "errhint" message, something like this:

WARNING: insufficient wal_level to publish logical changes
HINT:  Set wal_level to logical before creating subscriptions.

--

Lucas Viecelli


Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [PATCH v4] Add \warn to psql
Next
From: Ryan Lambert
Date:
Subject: Re: [Proposal] Table-level Transparent Data Encryption (TDE) and KeyManagement Service (KMS)