Re: warning to publication created and wal_level is not set to logical - Mailing list pgsql-hackers

From Lucas Viecelli
Subject Re: warning to publication created and wal_level is not set to logical
Date
Msg-id CAPjy-54X9XUcDwNa10QCToC3-wcfo_ZoukEi=8CUwV+7M3Vq+A@mail.gmail.com
Whole thread Raw
In response to Re: warning to publication created and wal_level is not set to logical  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> Is a WARNING sufficient?  Maybe I'm misunderstanding something
> important, but I think the attempt should fail with a HINT to set the
> wal_level ahead of time.

I thought about this possibility, but I was afraid to change the current behavior a lot, but it's worth discussing.
 
 
I agree that it'd be nice to be noisier about the problem, but I'm
not sure we can do more than bleat in the postmaster log from time
to time if a publication is active and wal_level is too low.
(And we'd better be careful about the log-spam aspect of that...)

I agree on being noisier, but I think the main thing is to let the user aware of the situation and in that the 
patch resolves, stating that he needs to adjust wal_level. Initially WARNING will appear only at the time 
the publication is created, precisely not to put spam in the log.

Is it better to warn from time to time that wal_level needs to change because it has some publication that will not work?
--

Lucas Viecelli


pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: GiST VACUUM
Next
From: Haribabu Kommi
Date:
Subject: Re: Transaction commits VS Transaction commits (with parallel) VSquery mean time