Postgres Pro
Downloads
Home   >   mailing lists

PATCH: Avoid use of __attribute__ when building with old Sun compiler versions - Mailing list pgsql-hackers

From Andy Grundman
Subject PATCH: Avoid use of __attribute__ when building with old Sun compiler versions
Date
Msg-id CAPjXLdGvomgzPYcKuRukR7u2D7w8tEykwcPQAAOQAfTGckGXfg@mail.gmail.com
Whole thread Raw
Responses Re: PATCH: Avoid use of __attribute__ when building with old Sun compiler versions  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view 
Hi,

The use of __attribute__ is currently enabled by checking for
__SUNPRO_C. However, this compiler only added support for
__attribute__ keywords in version 5.10 [1]. This patch adds a version
check to only enable this for supported versions [2].

I have tested this with Sun C 5.8 on a Solaris 9 SPARC system,
building 9.5.4 (+OpenSSL 1.1.0 patches).

[1] Compiler features by release:
http://www.oracle.com/technetwork/systems/cccompare-137792.html
[2] Pre-defined compiler macros:
https://sourceforge.net/p/predef/wiki/Compilers/#oracle-solaris-studio

Thanks,
--
Andy Grundman // andyg@activestate.com
Attachment

pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: Re: PROPOSAL: make PostgreSQL sanitizers-friendly (and prevent information disclosure)
Next
From: Kevin Grittner
Date:
Subject: Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling)