Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Style, remove redudant test "if (zeropadlen > 0)" - Mailing list pgsql-hackers

From John W Higgins
Subject Re: [PATCH] Style, remove redudant test "if (zeropadlen > 0)"
Date
Msg-id CAPhAwGzh_AcLzVbpJ=jfhu6W142OS0xw_tqJZywMbopv1P=1sA@mail.gmail.com
Whole thread Raw
In response to [PATCH] Style, remove redudant test "if (zeropadlen > 0)"  (Ranier Vilela <ranier_gyn@hotmail.com>)
Responses RE: [PATCH] Style, remove redudant test "if (zeropadlen > 0)"  (Ranier Vilela <ranier_gyn@hotmail.com>)
List pgsql-hackers
Tree view


On Sun, Nov 24, 2019 at 8:12 AM Ranier Vilela <ranier_gyn@hotmail.com> wrote:
Hi,
The test "if (zeropadlen > 0)" is redundant and can be salely removed.
It has already been tested in the same path.

Best regards,
Ranier Vilela

--- \dll\postgresql\a\port\snprintf.c   2019-11-23 13:19:20.000000000 -0300
+++ snprintf.c  2019-11-24 13:02:45.510806400 -0300

Could you please at least take the time to produce a patch that actually applies properly? 

If the patch does not have the proper path from the root of the source tree than it is completely worthless to most folks because it's really not appropriate to ask someone to fix your patch when the tools are clearly available to properly produce a patch without any issue.

Specifically git diff does this without issue.

Thanks in advance

John

pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: RE: [PATCH] Style, remove redudant test "if (zeropadlen > 0)"
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Possible arithmetic with NULL pointer or test "stack_base_ptr != NULL" is irrelevant.