Re: [Proposal] Level4 Warnings show many shadow vars - Mailing list pgsql-hackers

From John W Higgins
Subject Re: [Proposal] Level4 Warnings show many shadow vars
Date
Msg-id CAPhAwGzJpwpnvj_D8VTecGsog85=R1tOeMHJEMtvRFxR84ssbw@mail.gmail.com
Whole thread Raw
In response to RE: [Proposal] Level4 Warnings show many shadow vars  (Ranier Vilela <ranier_gyn@hotmail.com>)
Responses RE: [Proposal] Level4 Warnings show many shadow vars  (Ranier Vilela <ranier_gyn@hotmail.com>)
List pgsql-hackers


On Tue, Dec 10, 2019 at 5:21 AM Ranier Vilela <ranier_gyn@hotmail.com> wrote:
New version the global patch, with the considerations.
Unfortunately WalReceiverConn cannot be used because it is currently the typedef name for the structure.
I switched to WalReceiverConnection, it was long but it looks good.
RedoRecPtr proper name has no consensus yet, so it was still lastRedoRecPtr.


For someone that expounds consistency - this patch is the furthest thing from it.

In some places names are randomly changed to have an underscore (authmethodlocal to authmethod_local with the obvious inconsistency as well) - in some places names are changed to remove underscores (stop_t to stopt). Some places random letters are added (checkPoint to xcheckPoint) some places perfectly good names are truncated (conf_file to file).

Random places remove perfectly good prefixes and replace with single letters (numTables to nTables)

Random places switch from lower case names to upper case names (sentPtr to WalSentPtr) most places leave lower case names (days to ndays).

Please at least be consistent within the patch itself.....

John W Higgins

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Windows buildfarm members vs. new async-notify isolation test
Next
From: Tom Lane
Date:
Subject: Re: Unicode normalization test broken output