Obsolete TODO item "-Wcast-align" ? - Mailing list pgsql-hackers

From Christian Convey
Subject Obsolete TODO item "-Wcast-align" ?
Date
Msg-id CAPfS4ZzxDru4fJN9vnTP80_tdjwxdXo-KfJ9RVQSHP_5qEXqCw@mail.gmail.com
Whole thread Raw
Responses Re: Obsolete TODO item "-Wcast-align" ?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi guys,

I'm trying to get my feet wet in PG development, but I ran into a snag
with the TODO item I picked.  Could someone please tell me if I'm
making an obvious error?

I chose this item from the TODO page: "[E] Remove warnings created by
-Wcast-align".  It didn't have a check-mark after the "[E]", which I
took to mean it's an outstanding issue.

However, I'm starting to wonder if it's already been fixed:

(1) I wasn't able to reproduce it.  I built PG using:    * PG source commit 6591f4...  (a recent master/HEAD)    *
Ubuntu'spatched version of GCC 4.8.4    * "-Wcast-align"
 
but I didn't see anything in the compiler output indicating that the
warning got triggered.

(2) It looks like someone else tried to tackle this TODO item about
two years ago, but he also was unable to reproduce it:

https://www.postgresql.org/message-id/flat/CALgh3eseTDT9RspDi0AfhE0j0A3e%2B5XiS3ykQyhK7Z5RgPQTLA%40mail.gmail.com#CALgh3eseTDT9RspDi0AfhE0j0A3e+5XiS3ykQyhK7Z5RgPQTLA@mail.gmail.com

I didn't find any other discussions about that line-item via Google,
or by looking at the official/unofficial TODO-detail pages.

Thanks very much,
Christian Convey



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Better locale-specific-character-class handling for regexps
Next
From: Tomas Vondra
Date:
Subject: Re: Speed up Clog Access by increasing CLOG buffers