Re: pg_dump with tables created in schemas created by extensions - Mailing list pgsql-hackers

From Martín Marqués
Subject Re: pg_dump with tables created in schemas created by extensions
Date
Msg-id CAPdiE1xKf8kvhtTJGbtLOVVstyaZ6OsU1akOF-xRoLK58qE-pg@mail.gmail.com
Whole thread Raw
In response to Re: pg_dump with tables created in schemas created by extensions  (Stephen Frost <sfrost@snowman.net>)
Responses Re: pg_dump with tables created in schemas created by extensions  (Martín Marqués <martin@2ndquadrant.com>)
List pgsql-hackers
2016-08-24 11:15 GMT-03:00 Stephen Frost <sfrost@snowman.net>:
> Michael,
>
> * Michael Paquier (michael.paquier@gmail.com) wrote:
>> The patch attached includes all those tests and they are failing. We
>> are going to need a patch able to pass all that, and even for master
>> this is going to need more thoughts, and let's focus on HEAD/9.6
>> first.
>
> Are you sure you have the tests correct..?   At least for testagg(), it
> looks like you're testing for:
>
> GRANT ALL ON FUNCTION test_agg(int2) TO regress_dump_test_role;
>
> but what's in the dump is (equivilantly):
>
> GRANT ALL ON FUNCTION test_agg(smallint) TO regress_dump_test_role;

Yes, that was the problem there.

> I've not looked into all the failures, but at least this one seems like
> an issue in the test, not an issue in pg_dump.

I see the other 12 failures regarding the CREATE INDEX that Michael
reported but can't quite find where it's originated. (or actually
where the problem is)

--
Martín Marqués                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Vladimir Gordiychuk
Date:
Subject: Re: Stopping logical replication protocol
Next
From: Robert Haas
Date:
Subject: Re: Collective typos in contrib/postgres_fdw (Was: Re: Incorrect comment in contrib/postgres_fdw/deparse.c)