Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor - Mailing list pgadmin-hackers

From Shirley Wang
Subject Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor
Date
Msg-id CAPG3WN4wXo-hdzBHiFWsZo_L6DCRvZ=sejJmf3VKYJELVN=03Q@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor  (Robert Eckhardt <reckhardt@pivotal.io>)
Responses Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor
List pgadmin-hackers
Until we learn definitively from users that the current implementation of commenting/uncommenting in other tools is not working, we should use what is common practice. We can use that as a baseline and then if we learn that there needs to be another shortcut, we can add additional functionality. It's much easier to add something for users than to take away. 

On Fri, Jul 21, 2017 at 12:08 PM Robert Eckhardt <reckhardt@pivotal.io> wrote:
Right - we lose the ability to uncomment multiple levels though, which may also be useful.

Well yes. 

I would argue that simplicity trumps potential use. I'd also argue that attempting to maintain consistency across environments (IDEs, etc. ) is advantageous. This was the philosophy we were going with when enabling excel like behavior (also why I'm not fully happy with how it is today). 

-- Rob

pgadmin-hackers by date:

Previous
From: Surinder Kumar
Date:
Subject: Re: [pgAdmin4]: Webpacking of static JS/CSS
Next
From: Dave Page
Date:
Subject: Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor