Re: [PATCH] add relation and block-level filtering to pg_waldump - Mailing list pgsql-hackers

From David Christensen
Subject Re: [PATCH] add relation and block-level filtering to pg_waldump
Date
Msg-id CAOxo6XL+BRZhswS2XoOgiQQC1B-Acr0vC8GZC-4uNjWonfhK_g@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] add relation and block-level filtering to pg_waldump  (Japin Li <japinli@hotmail.com>)
List pgsql-hackers


On Fri, Feb 25, 2022 at 7:08 AM Japin Li <japinli@hotmail.com> wrote:

On Fri, 25 Feb 2022 at 20:48, David Christensen <david.christensen@crunchydata.com> wrote:
>> Cool.  I think we can report an error instead of reading wal files,
>> if the tablespace, database, or relation is invalid.  Does there any
>> WAL record that has invalid tablespace, database, or relation OID?
>
> The only sort of validity check we could do here is range checking for the underlying data types
> (which we certainly could/should add if it’s known to never be valid for the underlying types);

The invalid OID I said here is such as negative number and zero, for those
parameters, we do not need to read the WAL files, since it always invalid.

Agreed.  Can add some additional range validation to the parsed values.

David
 

pgsql-hackers by date:

Previous
From: David Christensen
Date:
Subject: Re: [PATCH] add relation and block-level filtering to pg_waldump
Next
From: Julien Rouhaud
Date:
Subject: Re: Expose JIT counters/timing in pg_stat_statements