Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL - Mailing list pgsql-hackers

From David Christensen
Subject Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL
Date
Msg-id CAOxo6X+t9BfKLJ0FSC2fOHNh8icOZ=LBmrkm1HxRmZuLxLjLUg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL  (David Christensen <david.christensen@crunchydata.com>)
Responses Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL
List pgsql-hackers
On Wed, Nov 9, 2022 at 2:08 PM David Christensen
<david.christensen@crunchydata.com> wrote:
> Justin sez:
> > I was wondering if there's any reason to do "CREATE DATABASE".  The vast
> > majority of TAP tests don't.
> >
> > $ git grep -ho 'safe_psql[^ ]*' '*pl' |sort |uniq -c |sort -nr |head
> >    1435 safe_psql('postgres',
> >     335 safe_psql(
> >      23 safe_psql($connect_db,
>
> If there was a reason, I don't recall offhand; I will test removing it
> and if things still work will consider it good enough.

Things blew up when I did that; rather than hunt it down, I just left it in. :-)

Enclosed is v7, with changes thus suggested thus far.

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: allow segment size to be set to < 1GiB
Next
From: Mark Wong
Date:
Subject: Re: real/float example for testlibpq3