Re: pldebugger targetinfo file missing - Mailing list pgadmin-hackers

From Dharmendra Goyal
Subject Re: pldebugger targetinfo file missing
Date
Msg-id CAOh5NjynXzcDG7x9Xj6E3_DYxF=kqcGo3Xir2ZhGju8E_ZcgxA@mail.gmail.com
Whole thread Raw
In response to Re: pldebugger targetinfo file missing  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgadmin-hackers
Hi Heikki,

I have been working to fix the build. I have fixed few issues but i am getting following error on Windows which needs other changes at code level.

plugin_debugger.c
    plugin_debugger.c(100): error C2099: initializer is not a constant

Following is the assignment which is causing the problem:
static debugger_language_t *debugger_languages[] = {
        &plpgsql_debugger_lang,
#ifdef INCLUDE_PACKAGE_SUPPORT
        &spl_debugger_lang,
#endif
        NULL
};

This seems to be working on Linux but on Windows it creates problem. 

Please find attached the changes which i have fixed so far.

Regards,

On Thu, Apr 19, 2012 at 5:55 PM, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> wrote:
On 19.04.2012 15:20, Dharmendra Goyal wrote:
Hi,

pldebugger build is failing on WIndows because targetinfo.c file is not
there where as vcproj file requires it to be there to build targetinfo.dll.
I checked earlier this file was there and after moving to git we started
seeing this issue.

If we have removed this file intentionally then it has to be removed from
vcproj file also.

Comments..??

Hmm, looks like I broke the Windows build with my recent changes. targetinfo.c file is gone, it's no longer needed as I rewrote the function that used to be in it in plain SQL.

I haven't tested on Windows, so it's very possible there's other stuff broken, too. Please let me know if so. Or even better, post a patch ;-).

--
 Heikki Linnakangas
 EnterpriseDB   http://www.enterprisedb.com



--
Dharmendra Goyal
Senior Software Engineer
EnterpriseDB Corporation
The Enterprise Postgres Company

Phone: +91-20-30589493
Mobile: +91-9552103323

Website: http://www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb

This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.

Attachment

pgadmin-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Direct debug dialog hangs in OnSize()
Next
From: Heikki Linnakangas
Date:
Subject: Re: pldebugger targetinfo file missing