Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Bug in get_partition_for_tuple - Mailing list pgsql-hackers

From Jeevan Ladhe
Subject Re: [HACKERS] Bug in get_partition_for_tuple
Date
Msg-id CAOgcT0MFpo1=Z3Qpiub0KLGuqS1sxgVpNNoZ+nSrkKht1_ArrA@mail.gmail.com
Whole thread Raw
In response to [HACKERS] Bug in get_partition_for_tuple  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: [HACKERS] Bug in get_partition_for_tuple  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
List pgsql-hackers
Tree view
Hi Amit,

I was able to reproduce the crash, and with the attached patch the crash goes
away. Also, "make check-world" passes clean.

Patch looks good to me. However, In following comment in your test:

-- check routing error through a list partitioned table when they key is null

I think you want to say:

-- check routing error through a list partitioned table when the key is null


Thanks,
Jeevan Ladhe


On Fri, Mar 10, 2017 at 8:26 AM, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote:
Just observed a crash due to thinko in the logic that handles NULL
partition key.  Absence of null-accepting partition in this case should
have caused an error, instead the current code proceeds with comparison
resulting in crash.

create table p (a int, b char) partition by list (b);
create table p1 partition of p for values in ('a');
insert into p values (1);   -- crashes

Attached patch fixes that and adds a test.

Thanks,
Amit


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


pgsql-hackers by date:

Previous
From: Rajkumar Raghuwanshi
Date:
Subject: Re: [HACKERS] wait events for disk I/O
Next
From: Amit Langote
Date:
Subject: Re: [HACKERS] Bug in get_partition_for_tuple