Re: Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs - Mailing list pgsql-hackers

From Atri Sharma
Subject Re: Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs
Date
Msg-id CAOeZVidy-xPc=TQAownb7qci_EUu8S-SLCiPppPDDWZdOqTwEg@mail.gmail.com
Whole thread Raw
In response to Re: Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs  (Pavan Deolasee <pavan.deolasee@gmail.com>)
List pgsql-hackers


On Tue, Jan 6, 2015 at 12:47 PM, Pavan Deolasee <pavan.deolasee@gmail.com> wrote:


On Tue, Jan 6, 2015 at 12:38 PM, Atri Sharma <atri.jiit@gmail.com> wrote:


May be what Amit has in mind is that the planner can choose the most optimal sorting algorithm using the hint that the dataset is probably already sorted. Actually why not just do that?  Though AFAIK its against our stated policy of not adding any planner hints.



I am not sure I totally understand your point. If the dataset is known to have exact order configuration as requested, why would we need the sort at all?

I would rather not mess around with the sort algorithm choosing mechanism anyways. IIUC, the standard way to hint about any existing order is to make a path and populate its pathkeys with the corresponding existing order pathkeys (ORDINALITY is the best example here that I can quote).

This is what the patch does. It does not in anyways force the planner or give it any planner hints, just an optional Path to evalutate. The Path has pathkeys specified in ORDER BY clause given at time of creation.


pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs
Next
From: Atri Sharma
Date:
Subject: Re: Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs