Postgres Pro
Downloads
Home   >   mailing lists

Re: Minimal logical decoding on standbys - Mailing list pgsql-hackers

From Rahila Syed
Subject Re: Minimal logical decoding on standbys
Date
Msg-id CAOajBXTA1T6Y69Ns5_zX479sZEiKO88tJNL9SxE82d_HV0DMFQ@mail.gmail.com
Whole thread Raw
In response to Re: Minimal logical decoding on standbys  (Amit Khandekar <amitdkhan.pg@gmail.com>)
Responses Re: Minimal logical decoding on standbys
List pgsql-hackers
Tree view
Hi Amit,

Please see following comments: 

1.  0002-Add-info-in-WAL-records-in-preparation-for-logical-s.patch

--- a/src/backend/access/hash/hashinsert.c
+++ b/src/backend/access/hash/hashinsert.c
@@ -17,6 +17,7 @@
 
 #include "access/hash.h"
 #include "access/hash_xlog.h"
+#include "catalog/catalog.h"
 #include "miscadmin.h"

The above header inclusion is not necessary as the code compiles fine without it. 
Also, this patch does not apply cleanly on latest master due to the above line.

2.  Following test fails with error.
make -C src/test/recovery/ check PROVE_TESTS=t/018_standby_logical_decoding_xmins.pl
#   Failed test 'physical catalog_xmin not null'
#   at t/018_standby_logical_decoding_xmins.pl line 120.
#          got: ''
#     expected: anything else

#   Failed test 'physical catalog_xmin not null'
#   at t/018_standby_logical_decoding_xmins.pl line 141.
#          got: ''
#     expected: anything else

#   Failed test 'physical catalog_xmin not null'
#   at t/018_standby_logical_decoding_xmins.pl line 159.
#          got: ''
#     expected: anything else
t/018_standby_logical_decoding_xmins.pl .. 20/27 # poll_query_until timed out executing this query:
# 

Physical catalog_xmin is NULL on master after logical slot creation on standby .

Due to this below command in the test fails with syntax error as it constructs the SQL query using catalog_xmin value 
obtained above:

# SELECT catalog_xmin::varchar::int >
# FROM pg_catalog.pg_replication_slots
# WHERE slot_name = 'master_physical';
#
# expecting this output:
# t
# last actual query output:
#
# with stderr:
# ERROR:  syntax error at or near "FROM"
# LINE 3:   FROM pg_catalog.pg_replication_slots

Thank you,
--
Rahila Syed
Performance Engineer
2ndQuadrant 
http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Let people set host(no)ssl settings from initdb
Next
From: Amit Kapila
Date:
Subject: Re: PATCH: logical_work_mem and logical streaming of largein-progress transactions