Thanks for the new round of reviews!
> 1) The new file
010_links.pl added should be included to meson.build also
> 2) Since it is a new file, "Copyright (c) 2021-2025" should be
> "Copyright (c) 2025"
Done!
> 3) Since it is a single statement, no need of braces here
I missed removing the braces along with the warning hint in
the previous version. Adjusted.
> Also give it a different number than any existing file -- if we
> already have an 010 in that directory then make this one something
> else. 012, 050, or whatever makes most sense.
The snippet that Vignesh quoted in his reply was from the
meson.build file of pg_basebackup instead of from
pg_combinebackup.
Attaching the new version of the patch in this reply.
properly handle Windows, as the meson tests on
Windows had complaints with the code of v3:
* copy_file.c was forcing CopyFile on Windows regardless
of the option chosen by the user. Now, to make that behavior
backward compatible, I'm only forcing CopyFile on Windows
when the copy method is not --link. That allows my patch to
work, and doesn't change the previous behavior.
* Had to normalize paths when performing string matching in
the test that verifies the hard link count on files.
Best regards,
Israel.
