Postgres Pro
Downloads
Home   >   mailing lists

Re: Proposal: Make cfbot fail on patches not created by "git format-patch" - Mailing list pgsql-hackers

From Jacob Champion
Subject Re: Proposal: Make cfbot fail on patches not created by "git format-patch"
Date
Msg-id CAOYmi+=ouL0ODvKJ21zN0+tGR5gEo7eHH7GjiTcs+Z8GDzsB2w@mail.gmail.com
Whole thread Raw
In response to Re: Proposal: Make cfbot fail on patches not created by "git format-patch"  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On Fri, May 16, 2025 at 12:12 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> That outcome seems entirely horrible to me.  If you want to flag the lack
> of a commit message somehow, fine, but don't prevent CI from running.

Personally I also prefer nudges to gates. Just like people already
deprioritize "Waiting on Author" entries a bit, having an obvious
"Patch Needs Work" note might gently help newcomers iterate on their
first submissions (or even communicate where a patch is in the
lifecycle! e.g. a Bugfix entry where the patch is marked incomplete
might motivate someone to jump in to fix it).

--Jacob

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Proposal: Make cfbot fail on patches not created by "git format-patch"
Next
From: Srinath Reddy Sadipiralla
Date:
Subject: Re: Make wal_receiver_timeout configurable per subscription