Re: Showing applied extended statistics in explain Part 2 - Mailing list pgsql-hackers

From Tatsuro Yamada
Subject Re: Showing applied extended statistics in explain Part 2
Date
Msg-id CAOKkKFv49qmE39eRWuQQ94xbtGv_K0aaUZe3VDi0ZzPoRiGc1g@mail.gmail.com
Whole thread Raw
In response to Re: Showing applied extended statistics in explain Part 2  (Tatsuro Yamada <yamatattsu@gmail.com>)
List pgsql-hackers
Hi Tomas and All,
 
Attached file is a new patch including:
    6) Add stats option to explain command
    7) The patch really needs some docs (partly)

 >4) Add new node (resolve errors in cfbot and prepared statement)

I tried adding a new node in pathnode.h, but it doesn't work well.
So, it needs more time to implement it successfully because this is 
the first time to add a new node in it.
 
8) Add regression test (stats_ext.sql)

Actually, I am not yet able to add new test cases to stats_ext.sql.
Instead, I created a simple test (test.sql) and have attached it.
Also, output.txt is the test result.

To add new test cases to stats_ext.sql,
I'd like to decide on a strategy for modifying it. In particular, there are 
381 places where the check_estimated_rows function is used, so should I 
include the same number of tests, or should we include the bare minimum 
of tests that cover the code path? I think only the latter would be fine.
Any advice is appreciated. :-D

P.S.
I'm going to investigate how to use CI this weekend hopefully.

Regards,
Tatsuro Yamada

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: pg_createsubscriber: drop pre-existing subscriptions from the converted node
Next
From: Amit Langote
Date:
Subject: Re: pgsql: Add more SQL/JSON constructor functions