Re: pgbench - allow backslash continuations in \set expressions - Mailing list pgsql-hackers

From Rafia Sabih
Subject Re: pgbench - allow backslash continuations in \set expressions
Date
Msg-id CAOGQiiP_7bJ2-+yspBnsQJUzV6A+Fk=9MgJQ2h9y4ic_i7=BEA@mail.gmail.com
Whole thread Raw
In response to Re: pgbench - allow backslash continuations in \set expressions  (Christoph Berg <myon@debian.org>)
Responses Re: pgbench - allow backslash continuations in \set expressions  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
Hie Fabien,
Seems like an interesting addition to pgbench interface, but not sure where it's required, it'll be good if you may provide some cases where it's utility can be witnessed. Something like where you absolutely need continuations in expression.

While applying it is giving some trailing whitespace errors, please correct them.
As an additional comment you may consider  reformatting following snippet
{continuation} { /* ignore */ }

  as
{continuation}
/* ignore */ 
}
Thanks.

On Mon, Oct 3, 2016 at 6:16 PM, Christoph Berg <myon@debian.org> wrote:
Re: Fabien COELHO 2016-10-03 <alpine.DEB.2.20.1610031259400.19411@lancre>
> > I "\set" a bunch of lengthy SQL commands in there, e.g.
>
> I agree that this looks like a desirable feature, however I would tend to
> see that as material for another independent patch.

Sure, my question was by no means intending to stop your pgbench patch
from going forward by adding extra requirements.

> Hmmm. I'm not sure how this is parsed. If this is considered a string '...',
> then maybe \set should wait for the end of the string instead of the end of
> the line, i.e. no continuation would be needed...
>
>  \set config '
>     SELECT name, ...
>            CASE ... END
>     FROM pg_settings
>     WHERE ...;'

I guess that would be the sane solution here, yes. Not adding any \
chars at the end of the line would also mean cut-and-paste of the RHS
content would work.

Thanks for the feedback!

Christoph


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



--
Regards,
Rafia Sabih

pgsql-hackers by date:

Previous
From: Haribabu Kommi
Date:
Subject: Re: [BUGS] BUG #14350: VIEW with INSTEAD OF INSERT TRIGGER and COPY. Missing feature or working as designed.
Next
From: Michael Paquier
Date:
Subject: Re: commit fest manager for CF 2016-11?