Re: Patch for SonarQube code scan. - Mailing list pgadmin-hackers

Hi,

Please fix PEP8 issues. Other than PEP8, everything looks good to me.

Thanks,

Khushboo

On Fri, Jun 26, 2020 at 10:08 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

On Fri, Jun 26, 2020 at 10:02 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:

Hi Khushboo,

Details as follows:

1. Package files:

1. Refactor this function to reduce its Cognitive Complexity from 40 to the 15 allowed.

2. Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.

2. Functions files:

1. Rename this local variable "argString" to match the regular expression ^[_a-z][a-z0-9_]*$.

2. Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.

Thanks,

Nikhil Mohite.

Thanks. 

On Fri, Jun 26, 2020 at 9:48 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi Nikhil,

Can you please provide the details of the issue provided by SonarQube (so review would be easy) ? 

Thanks,

Khushboo

On Fri, Jun 26, 2020 at 9:31 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:

Hi Team,

I have fixed some code smell issues in SonarQube scan.

1. Code smells in packages init file.

2. Code smells in function init file (not fixed all code smell will send new path for it).

Regards,

Nikhil Mohite.