Postgres Pro
Downloads
Home   >   mailing lists

Re: Avoid useless retrieval of defaults and check constraints in pg_dump -a - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: Avoid useless retrieval of defaults and check constraints in pg_dump -a
Date
Msg-id CAOBaU_bmc1Ck4VygNxZ81HrEZ1VTkC-8BWYz0MhJOtUU46v-aQ@mail.gmail.com
Whole thread Raw
In response to Re: Avoid useless retrieval of defaults and check constraints in pg_dump -a  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Avoid useless retrieval of defaults and check constraints in pg_dump -a  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On Tue, Sep 15, 2020 at 4:48 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, Sep 10, 2020 at 02:31:32PM +0200, Daniel Gustafsson wrote:
> > Given how unintrusive this optimization is, +1 from me to go ahead with this
> > patch.  pg_dump tests pass.  Personally I would've updated the nearby comments
> > to reflect why the check for dataOnly is there, but MMV there.  I'm moving this
> > patch to Ready for Committer.
>
> We need two comments here.  I would suggest something like:
> "Skip default/check for a data-only dump, as this is only needed for
> dumps of the table schema."
>
> Better wording is of course welcome.

FWIW I'm fine with those news comments!

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Use incremental sort paths for window functions
Next
From: Matthias van de Meent
Date:
Subject: Re: [patch] _bt_binsrch* improvements - equal-prefix-skip binary search