Re: Avoid incorrect allocation in buildIndexArray - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: Avoid incorrect allocation in buildIndexArray
Date
Msg-id CAOBaU_biM4rV7cdYVZkY5T3D9hXQWV5Gyiz9uecszLLo7CpqTA@mail.gmail.com
Whole thread Raw
In response to Avoid incorrect allocation in buildIndexArray  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Avoid incorrect allocation in buildIndexArray  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Fri, Sep 11, 2020 at 1:39 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> Looking at a pg_dump patch I realized that when we call buildIndexArray without
> having found objects to index, we still call pg_malloc with zero which in turn
> mallocs 1 byte.  The byte in question is of course negligable, but it does seem
> cleaner to return early with NULL instead of returning an empty allocation
> which doesn't actually contain an index.
>
> Any reason not to bail early as per the attached?

+1



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Avoid incorrect allocation in buildIndexArray
Next
From: Ranier Vilela
Date:
Subject: Re: Avoid incorrect allocation in buildIndexArray